[Israel.pm] Classifier

Offer Kaye oferk at oren.co.il
Tue Jun 8 00:17:52 PDT 2004


>
> Hello,
>
> I've been implementing today a very simple, yet very useful
> classification algorithm(s):
> 	Perceptron
> and
> 	Winnow
>

[...snip...]

>
> Any comments?
>
> --
> Shlomo Yona

Just a couple of comments:
1. In the example.perl code, there is no need to do "use lib './';", since
"." is already in @INC by default.
2. In Classifier.pm,  you use many one-letter variables, such as $x, $y, $t,
and even the dreaded "use strict doesn't work on me" $b :-) We just had a
long thread on this subject- are you still not convinced that such variable
names are a Bad Thing(tm)?

Regards,
----------------------------------
Offer Kaye




More information about the Perl mailing list